critique dies when a file is removed

[flimzy]

When I updated my git checkout, some files and directories were removed. Now critique dies when it comes to them, and I find no option to skip:

=============================================================================================================================================================================================================================================
Running Perl::Critic against (apps/oozie/workflows/ranking-nbl-v2/export.pl)
---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
Can't parse code: Did not pass a PPI::Tokenizer object to PPI::Lexer::lex_tokenizer

[flimzy]

(My work-around was to 'touch' the missing file, then remove it again after critique continued)

[stuartskelton]

I suspect #29 should fix this too.

[flimzy]

29 should solve the immediate symptom, but I wonder if the critique meta data should also be updated to no longer reflect the missing files?

[stuartskelton]

That certainly is possible.

On 6 Sep 2016 12:32 p.m., "Jonathan Hall" notifications@github.com wrote:

29 https://github.com/stevan/p5-App-Critique/pull/29 should solve the

immediate symptom, but I wonder if the critique meta data should also be updated to no longer reflect the missing files?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/stevan/p5-App-Critique/issues/30#issuecomment-244923705, or mute the thread https://github.com/notifications/unsubscribe-auth/AAc1FqfWpxLOVjD2TBHxuiQVTNWEwOLvks5qnU9dgaJpZM4J1jtP .

[stevan]

I think something like a rebase command would make sense. It would need to remove files which were removed, but also it should probably re-enqueue any modified files as well.