A single pre-resolved promise passed to collect fails

stevan / promises-perl

An implementation of Promises in Perl

31 stars 29 forks source link

A single pre-resolved promise passed to collect fails #29

Closed clintongormley closed 10 years ago

clintongormley commented 10 years ago

because $all_done is already resolved.

Check if $all_done is still in progress before resolving. Tests added.

Fixes #28

oschwald commented 10 years ago

:+1:

stevan commented 10 years ago

Good enough for @clintongormley is good enough for me, merged! @oschwald, does this require immediate release? or can I wait until some more features/fixes accumulate?

oschwald commented 10 years ago

@stevan, I came across this while making unit tests for my own code. Having this released would make those tests a bit simpler, but I am fine either way.

stevan commented 10 years ago

@oschwald I will shoot to get it out the door in the next day or two.

oschwald commented 10 years ago

Thanks!

stevan commented 10 years ago

@oschwald sorry it took so long to get this release out, but I have just pushed this to CPAN now

oschwald commented 10 years ago

Great. Thanks!