search

stevan / promises-perl

An implementation of Promises in Perl
31 stars 29 forks source link

Make Mojo::IOLoop recommended instead of required. #31

Closed clintongormley closed 10 years ago

clintongormley commented 10 years ago

Mojolicious requires Perl 5.10, while Promises with AnyEvent works on Perl 5.8.

This PR allows the test suite to run on Perl 5.8.9 when Mojo::IOLoop is not installed. Also needs the META file to be updated.

Would appreciate a new release soon as this is all that is blocking my async Elasticsearch release.

thanks stevan

stevan commented 10 years ago

@clintongormley will release it right now.

stevan commented 10 years ago

@clintongormley done and up on PAUSE, enjoy!

clintongormley commented 10 years ago

Sorry @stevan , but it is still listed as "required" in the META file: https://metacpan.org/source/STEVAN/Promises-0.92/META.yml#L25

ta

stevan commented 10 years ago

Yeah, I got this RT bug this morning (https://rt.cpan.org/Public/Bug/Display.html?id=92272) and realized that. I will try and look into it today and see what I can do.

stevan commented 10 years ago

@clintongormley should be fixed now (0.93), my fault for shooting from the hip and not checking to see what dzil was actually doing.

clintongormley commented 10 years ago

Working nicely - many thanks