search

steve-jansen / cordova-ios-emailcomposer

A Cordova plugin for creating e-mail messages on iOS devices
MIT License
14 stars 4 forks source link

Fix a semantic issue #3

Closed samdunne closed 11 years ago

samdunne commented 11 years ago

Xcode fails the build as a semantic issue.

steve-jansen commented 11 years ago

@samdunne

Thank you for the fix!

D'oh - I missed this one because I use ARC in all my cordova projects. I totally forgot to see what happens when the conditional compilation hits the non-ARC code.

Cheers, Steve

samdunne commented 11 years ago

No problem. Luckily xcode all but gives you the fix :)

steve-jansen commented 11 years ago

FYI - I just pushed the fix as release v2.0.2 to the cordova registry (http://plugins.cordova.io/#/emailcomposer) in the event you need to use cordova plugins add emailcomposer with a non-ARC project.

samdunne commented 11 years ago

Thanks :). I just manually fixed it my end when I sent the pull request. No need to update for me anyway