search

steve-ochoa / osu_cs_361_longbourn

Longbourn Foxes Team Repo
1 stars 3 forks source link

add new skill / course / company from expert profile page currently allows addition of blank skills / courses / companies #39

Closed contip closed 3 years ago

contip commented 3 years ago

currently, going to the expert profile page, clicking on add new skill, and then submitting without entering any skill data in, actually creates an empty skill in the db and associates it with the expert:

image

implement basic pre-submission validation to prevent this from being possible (also occurs when adding a new course or company)

contip commented 3 years ago

addressed here 4016a52c1c3cc60c8c69d3b6744a43dd8b19b4db

implemented simple "all fields required" check when attempting to add new skill, course, or company from expert profile page

image

same check also added to registration form pages, but allows registering user to click "next" without entering any skills, courses, or companies..

eg, clicking next in this situation works and redirects to next registration page: image

eg, clicking next in these situations does NOT work: image (experience years left blank)

image (two skills filled out completely, last skill missing experience years)