Condition 'p>=1' is always true

[steve-the-bayesian]

Codacy detected an issue:

Message: Condition 'p>=1' is always true

The variable 'p' is a 'double' argument to a function. In the application 'p' is a probability so the assertion "p>=1" is always true is false. I'm getting this warning in several places, and consider it to be an error.

Occurred on:

• Commit: 881ca2d27b000735682623e669cc46770fa74c9b
• File: distributions/usp.cpp
• LineNum: 65
• Code: if (p <= 0 || p >= 1) {

Currently on:

• Commit: 36560ae6777ee907c8bd1c6a6ee2ec814bc64fe9
• File: distributions/usp.cpp
• LineNum: 65

[steve-the-bayesian]

This is a bug in codacy, not in Boom.