search

steve0511 / resty-redis-cluster

Openresty lua client for redis cluster.
Apache License 2.0
376 stars 134 forks source link

(feat) support granular connection timeouts #65

Closed vinayakhulawale closed 4 years ago

vinayakhulawale commented 4 years ago

As per lua-resty-redis's docs set_timeouts should be preferred over set_timeout

All tests are passing

docker run -d --rm  -e "IP=0.0.0.0" -p 7000-7006:7000-7006 grokzen/redis-cluster:latest && sleep 10 && make test
e0b1a05315e88dbf86f4449c612bb6359a6b8ed76ea0626ecad0f665a6d7d025
PATH=/<***prefix***>/nginx/sbin:$PATH prove -I../test-nginx/lib -r t
t/sanity.t .. ok
All tests successful.
Files=1, Tests=78, 13 wallclock secs ( 0.03 usr  0.02 sys +  0.50 cusr  0.80 csys =  1.35 CPU)
Result: PASS
vinayakhulawale commented 4 years ago

@steve0511 - please review this PR, when you get time.

steve0511 commented 4 years ago

LGTM, thanks fix that.