Closed 0xValJohn closed 1 year ago
Resolved your one comment on my latest commits. There's still some small conversations that should be wrapped up when you have a moment. After that, I just have to get work with the compile errors I am getting due to the libraries that mellow depends on. Once that's all good, we can move on to a new PR where we focus on tests.
FYI - I am using these libraries in the math affiliated with checking the capacity remaining within the mellow strategy itself when calling adjustPosition()
.
Also corrected the compilation errors I was getting before after talking with foundry support. Here's the answer I was given:
Paul R. Berg, [Feb 12, 2023 at 3:55:51 PM]:
...git submodule deinit -f .
git submodule update --init --recursive
I use commands above in a bash function, like this
function reinit() {
git submodule deinit -f .
git submodule update --init --recursive
}
Rebooting submodule is often necessary when switching between branches
Final compiler issues have been resolved. There may be more adjustments to be made, especially with importing code from mellow protocol in the last couple of commits.
If you are good with the changes included in this one, let's merge it. We can tackle new issues and tests in a new PR as discussed.
I am closing PR #6 as discussed too.
As per asynchronous conversation with @0xValJohn, he has reviewed this PR and we can merge it now. We will focus on two main avenues moving forward:
Hey @0xValJohn, please see the changes I've made for the following. I assume there will be compile errors, especially with bringing in the internal functions from Mellow protocol as per our convo with Dmitriy. I'm pausing for today but if you have thoughts on the error / any of the changes before I get back to it, please let me know.
TODO:
adjustPosition()
as per conversations with Mellow core contributorsNOTES: