search

steve1316 / granblue-automation-pyautogui

Educational application aimed at automating user-defined workflows for the mobile game, "Granblue Fantasy", using a variety of CV technologies in the backend such as OpenCV, PyAutoGUI and EasyOCR and a frontend coded in Typescript.
https://github.com/steve1316/granblue-automation-pyautogui/wiki
120 stars 36 forks source link

Stuck at support selection #62

Closed KoiKomei closed 3 years ago

KoiKomei commented 3 years ago

As per title, it seems that the bot gets stuck during summon selection for no reason, it clicks on the element and then just stalls infinitely, I don't know what might be the cause, it happens randomly.

Screenshot_83

Update: it seems that sometimes it just skips every support image except the last summon Screenshot_500

steve1316 commented 3 years ago

I reworked the Summon Selection system recently.

The old method was searching one summon at a time. If it reached the bottom of the page, then it will scroll all the way back up and do the same thing again for the next summon. If it reaches the bottom of the page and none of your summons were detected, then it will reset summons.

The new method now searches for all summons simultaneously. If there are no summons that you picked on the screen, then it will scroll once and then searches for all summons simultaneously again, then repeat, etc until it reaches the bottom of the page and then it will reset summons.

I did this to save time if your 4th summon was already at the top of the page and saves time that way instead of scrolling all the way down 3 more times.

I will test it more on my end to see if the bot gets stuck infinitely due to this.

EDIT: Just finished an hour of testing on both Raid and Special farming modes with various summons. I experienced the intended behavior and did not encounter any instance where the bot did not do anything.

KoiKomei commented 3 years ago

Quite weird, I'll do more through tests whenever I get free. I'd also have to say that this behaviour happens ONLY on my laptop, so it might be some bug/unintended behaviour with the image recognition library.

Will keep you updated.

NeapolitanIcecream commented 3 years ago

Experiencing the same problem. Did not observe the scrolling nor logs reporting errors.

steve1316 commented 3 years ago

Thank you for the simple fix! Merged your pull request.