steve1rm / BusbySurvey

Fetches and conducts a user suvery
MIT License
0 stars 0 forks source link

Start of the code review process 👋 #18

Open luongvo opened 4 months ago

luongvo commented 4 months ago

Hi @steve1rm 👋 , thank you for your effort on the code submission. I am Lucas, Technical Lead at Nimble, and I am happy to be the reviewer for our code review session.

During the review process, I would like to know more about your decisions, so I will create issues in some areas where there could be more improvements regarding your submission. Since solving every possible problem would take too long, I will prioritize the most important ones.

At the same time, please keep in mind that this is a bi-directional process, and I would love to hear back from you as well. Therefore, do not hesitate to ask questions or share your opinions about the implementation (if any) during the process.

We expect the code review process to be completed within 2-3 days. As a result, please make sure you are responsive during this process. If you need more time, please let us know as soon as possible so we can plan accordingly.

If we are aligned on any issue, and you would like to correct them, please address the issue using a proper git flow (creating a new branch, opening a Pull Request (PR) per issue, and merging the code when you are ready), and I will follow up on those fixes. Just so you know, you don't have to close any of my created issues after merging your PRs; I will help verify and close them for you once they pass. 😇

In the end, I do hope that you find the process enjoyable. Good luck and happy coding. 🤘

steve1rm commented 4 months ago

@luongvo Just to update you on the timeline. Sunday to Wednesday I will be traveling so my response might be slower during those days.

luongvo commented 4 months ago

Hi @steve1rm, we completed the code challenge evaluation step. Please wait for the final result from the recruitment team. Thank you for your collaboration 🤗

steve1rm commented 4 months ago

Hi @luongvo I have just replied back to all issues and created PRs for the prioritized ones