codepathreview
commented
7 years ago Decent work. A few notes after checking out the code:
- Nice to see you properly reused the single base method in search activity to fetch results for both initial load and the pagination.
- Consider moving the search field into the ActionBar using a custom ActionBar layout or with a SearchView
- Nice to see you properly used spinners and checkboxes to allow users to select filters.
- One thing to consider is rather than sending and returning all the filter values separately as keys, might have introduced a serializable model (i.e
SearchFilters.java) representing all the filters - Nice to see you used Dagger and implemented MVP architecture. Such combination is considered good practice in the industry. Consider looking at Clean Architecture to further enhance app.
- Consider polishing UI and design using this guide
Also, here's a more detailed Project 2 Feedback Guide here which covers the most common issues with this submitted project. Read through the feedback guide point-by-point to determine how you could improve your submission.
Let us know if you have any other thoughts or questions about this assignment. The next assignment (Twitter Client) will be especially important since it introduces the majority of the remaining pieces necessary to build a fully functional API client with complex feeds of data and user creation.
Hello Steve,
Looks like your submission missing the required feature: [ ] User can click on "settings" which allows selection of advanced search options to filter results. Can you please double-check that you completed the feature, update your code and/or README and then re-submit your project through the course system.