steve228uk / YouTube-Music

:musical_note: A Mac app wrapper for music.youtube.com
https://ytmusic.app
MIT License
2.78k stars 203 forks source link

Mac M1 Support #147

Closed DenisStetsenko closed 2 years ago

DenisStetsenko commented 3 years ago

Do you guys know any info about Mac M1 support for this app?

arigato-one commented 3 years ago

I am using it on a Mac M1, works great.

TechRemarker commented 3 years ago

Same question. And in regards to one of the commenters... nearly all apps will 'work' on M1 because of Rosetta other than some very rare exceptions such as running Windows on Mac. But what the author is asking here is there a version of the app designed for M1 rather than Intel.

Currently the main app shows has not designed for M1. Is there a beta M1 version available or timeline on an update?

image

DenisStetsenko commented 3 years ago

But what the author is asking here is there a version of the app designed for M1 rather than Intel.

TimOliver commented 3 years ago

Hey folks! Yep, this thing is on my radar. The reason why the app didn't have M1 support from the start was that since we're producing builds with GitHub Actions, which was stuck on macOS 10.15 for a bit longer than expected, it wasn't possible to produce M1 builds with it.

And now that GitHub Actions has finally moved to Big Sur, the dependencies of the build script have changed and it's stopped working. Ahh software. 🤣

I'll set aside some time to fix the build script and hopefully that's all that's needed to enable Universal builds now. Thanks!

TechRemarker commented 3 years ago

Awesome thank you!

TimOliver commented 3 years ago

Hey everyone!

Sorry for the delay! I just released version 1.2.0 which should now include a working arm64 slice for Apple Silicon Macs.

Can you please test it and let me know how it goes? Thanks!

TechRemarker commented 3 years ago

Awesome, just got my new M1 yesterday. While the website still shows the old version, grabbed the newest from GitHub here. It shows now as a universal binary. When installing asked my to enable an accessibility setting (don't remember that being required before but maybe it was?) Other than that hurdle some may not like, installed without a problem. Logged into my account in the app and played a few songs. So far so good! Also the keyboard pause/play forward/back etc all seem to controlling the app normally as expected.

pertsevds commented 3 years ago

Got 1.2.0 version from Github. Same experience as Chris. Overall works well + app asks for Accessibility rights that it didn't ask on version from website. Thank you for M1 version.

TimOliver commented 2 years ago

Cool thanks guys! Good to hear it's working properly on M1 hardware. I've got an M1 Max MacBook Pro coming in the mail soon. I can't wait!

Yeah, I don't have access to the website, so I can't upload new builds there. I'll have to ask Steve about that.

Right. The accessibility request is from another PR that was filed to try and globally hook the media control keys when the app is active to enable forward and back support. There's an issue with this app still where the internal web view hooks control of the video player, but it's not smart enough to know what the next song is.

It seems like maybe the behaviour has become better in Monterey, so maybe we don't need to rely on that media hooking library anymore, but we'd need to test it. We can discuss this in another issue.

In any case, enjoy!