search

steve228uk / YouTube-Music

:musical_note: A Mac app wrapper for music.youtube.com
https://ytmusic.app
MIT License
2.78k stars 203 forks source link

Search box is now part of the title bar, causing issues with selecting text via mouse #161

Closed jscheel closed 1 year ago

jscheel commented 2 years ago

If you try to double click text in the search bar to select all, it maximizes the window. If you try to drag-select text, it moves the app window. I'm guessing this came from https://github.com/steve228uk/YouTube-Music/pull/151

TimOliver commented 2 years ago

Oh no. Yeah that sounds like that other PR introduced a regression. 😅

Should we revert?

/cc @atom2ueki

atom2ueki commented 2 years ago

@jscheel @TimOliver

yes, there is an priority issue in-between search view and NSView action

https://github.com/steve228uk/YouTube-Music/blob/ad51b3ad98779e31cc73940597c6eac1b2ed1dfb/YT%20Music/Controllers/ViewController.swift#L81

https://github.com/steve228uk/YouTube-Music/blob/ad51b3ad98779e31cc73940597c6eac1b2ed1dfb/YT%20Music/Controllers/ViewController.swift#L154

these 2 places height previously was 20, when it increased to 64, NSView action will take a higher priority, I will raise a PR revert it back later

atom2ueki commented 1 year ago

@TimOliver Shall we close this ticket?

TimOliver commented 1 year ago

Sounds good. :)