search

steve228uk / YouTube-Music

:musical_note: A Mac app wrapper for music.youtube.com
https://ytmusic.app
MIT License
2.77k stars 202 forks source link

Block service worker from loading, (see #163) #164

Closed jscheel closed 2 years ago

jscheel commented 2 years ago

The YouTube Music service worker's prefetch and cache seems to be breaking. This PR disables the service worker so that the requests to pull the js reach the server, instead of a broken service worker. For this to work, it requires a min version bump to 10.13. See discussion on #163

TimOliver commented 2 years ago

Thanks @jscheel! Yeah, I think at this point, fixing this issue outweighs the need for backwards support, so I think bumping to 10.13 is fine. I'll prepare a new release ASAP!

buschtoens commented 2 years ago

I just saw this linked in the update notes and wanted to thank you @jscheel for fixing this bug. Thanks for making my daily life a bit better! ✨

jscheel commented 2 years ago

You're welcome @buschtoens, I hope it works for you! There's another PR in the works (#167) that may be needed as well.

TimOliver commented 2 years ago

Thanks so much for the new PR @jscheel!

I just merged it and cut a new release. It should already be live to update, so please give it a try and let me know how it goes for you! Thanks again!