search

steve228uk / YouTube-Music

:musical_note: A Mac app wrapper for music.youtube.com
https://ytmusic.app
MIT License
2.78k stars 203 forks source link

Make Global Shortcut for Play/Pause optional #169

Open ravero opened 2 years ago

ravero commented 2 years ago

Currently the app has mapped Command + Shift + Spacebar to Play/Pause. This is redudant with Media keys (on F8) and is also conflicting with another Keyboard shortcut that I have mapped for this.

I would like to ask for either adding this shortcut as a preference or make it customizable entirely. I've made a fork where I've disable this keyboard for my own usage, I'm thinking of adding a Preferences window that would allow having this setting on or off (maybe its a issue for others too). Let me know if you would be interested in have this as a PR for this project.

Regards.

karthicraghupathi commented 2 years ago

I'm having the same issue. I have that combination assigned to Moom so it's causing my music to start and stop whenever I resize a window.

It would be great if this shortcut was made optional as there is a dedicated media key for this option.

Authors / Maintainers, please consider accepting @ravero's solution as part of a PR #170.

ysquaredd commented 2 years ago

This also conflicts with the default 1password shortcut for me. I would rather keep the 1password shortcut and disable the play/pause since media keys are available.

ollynevard commented 2 years ago

This also conflicts with the default 1password shortcut for me. I would rather keep the 1password shortcut and disable the play/pause since media keys are available.

Same for me. I'd much rather keep the shortcut for 1password as I have media keys for play/pause. It would be great if the key bindings were configurable, or at least optional.

As it stands, I currently pause my music everytime I enter a password.

ravero commented 2 years ago

Well, there's a long time I have a PR opened with a solution for this issue. I have compiled my own version, I'm considering creating a fork of this project because it seems pretty much abandoned, so I can release an updated version.

TimOliver commented 2 years ago

I appreciate the vote of confidence, lads! 😅

Trying to work through the blockers in shipping a new release with the new PR included now!

vittorius commented 2 years ago

@TimOliver this issue still persists in 1.3.3