steve228uk / homebridge-magichome

A Homebridge plugin for Magic Wifi devices
MIT License
82 stars 47 forks source link

Improved handling of white channels #28

Open Ortner opened 6 years ago

Ortner commented 6 years ago

Features

A description of the options can be found in the sample configuration file (right below the plugin description - I assume this is the best place for the documentation). If the new options are not enabled, the plugin should behave as the previous version.

Solved issues

fixes #27: Use option combinedwhite=true see sample config for an example. fixes #15, fixes #12: There are several methods to control the white channels now. See sample config for an example. fixes #4: Use option onlywhite=true this will enable color temperature on RGBWW devices, but the color LEDs are permanently turned of. The RGB selection will still be available, as the change does not implement the color temperature characteristic

Ortner commented 6 years ago

PS: I tested it on a RGBWW controller only, so feel free to test it on the other devices too :-).

Kamonix commented 6 years ago

@Ortner I use your combinedwhite=true, but the white leds are always on. Is that right? I thought the brightness adapts. Like Philips Hue.

Ortner commented 6 years ago

Hi there,

it's been a while and I switched to OpenHAB to control the LEDs. So I can't verify it anymore, but the (intended) behaviour for combined white should be: RGBs are controlled by color (hue and saturation) and brightness setting and the white channels are only controlled by brightness. So unless you set brightness to zero, the white channels should always be on (to some extent - dimmed with the brightness slider). If you move between white and black, the white channels should become darker.

What is the behaviour of Philips Hue? Which version of the controller are you using? And please be aware, only one of the options should be true, all others must be set to false.

Zacknetic commented 6 years ago

Hey ortner, perhaps take a look at how I control warm white and cold white channels separately. It’s a pretty hacky way to do it and I’m sure you can find a better way. I also added support for GRB versions of the controller.

Kamonix commented 6 years ago

@Ortner What is the behaviour of Philips Hue? When I select for example red, only the rgb leds are on, but when I select a color near the white circle the white leds turn brighter. The white led turn not only on and off. They are mixed with the rgb's.

Which version of the controller are you using? I use v2 of these controller 16-millionen-farben-wifi-5-kan-le-rgb-ww-cw-led-controller-smartphone-steuerung-musik-und jpg_640x640

chymerix commented 6 years ago

@Ortner, does OpenHAB provide more natural control of the LEDs? I just recently tried Home Assistant, but the control is worse than Homebridge. I'm looking for a solution that works close to as seamlessly as the Philips Hue LED strips (i.e. the RGBW strip is controlled as one LED rather than two; setting the color varies the relative contribution of the RGB and W; changing brightness does so universally for the selected color)