2013-05-07 GC update: pre-filtering fails - fixed in SVN, release pending

[GoogleCodeExporter]

After a long time, encoding of D/T/size in search results seems to have changed 
- investigations are still under way.

If you used to filter by -d/-D, -t/-T, or -s/-S, and get an error similar to 
the following:

/.../geotoad/lib/filter.rb:71:in `block in terrainMax': undefined method `>' 
for nil:NilClass (NoMethodError)
    from /.../geotoad/lib/filter.rb:70:in `delete_if'
    from /.../geotoad/lib/filter.rb:70:in `terrainMax'
    from /.../geotoad/geotoad.rb:473:in `preFetchFilter'
    from /.../geotoad/geotoad.rb:920:in `<main>'

you may want to add the "-X" option to your command line (which had been 
created for exactly this thing to happen).

TUI users might try to add a single line

disableEarlyFilter: true

to their config.yaml file, then restart GeoToad.

Original issue reported on code.google.com by Steve8x8 on 8 May 2013 at 8:46

[GoogleCodeExporter]

Since not only D/T/size encoding has changed (back to where it was before 
Christmas 2010), but also distance and direction are given verbatim again, -X 
will only repair the worst misbehaviour.
It's kind of ironic that precise azimuths have become unavailable just a week 
after merging the (issue 213) patch into trunk, but c'est la vie.

Here's a first version of a patch that supposedly fixes this issue, and makes 
GeoToad fully operational again. I will continue testing (and if necessary, 
improving) it, and prepare an "emergency release" within the next few days.
Development users, and other people willing to test the patch, please keep a 
copy of lib/search.rb (or otherwise prepare to roll back)...

Original comment by Steve8x8 on 8 May 2013 at 9:35

• Changed state: Started

[GoogleCodeExporter]

Here's the patch, version 1

Original comment by Steve8x8 on 8 May 2013 at 9:37

Attachments:

• dts_dd.diff

[GoogleCodeExporter]

Several tests showed no regression, so I committed the patch both to trunk and 
branch (r1344).
Release(s) will follow next week.

Original comment by Steve8x8 on 8 May 2013 at 12:24

• Changed title: 2013-05-07 GC update: pre-filtering fails - fixed in SVN, release pending

[GoogleCodeExporter]

Phew, thanks for fixing so quickly :) 

Original comment by trak...@gmail.com on 8 May 2013 at 3:49

[GoogleCodeExporter]

Release 3.16.7 is out, the bug will be closed as soon as 3.17.8 has been 
released as well.

Original comment by Steve8x8 on 13 May 2013 at 10:14

• Changed state: FixAvail

[GoogleCodeExporter]

Closing.

Original comment by Steve8x8 on 27 May 2013 at 7:34

• Changed state: Fixed