steve8x8 / geotoad

Geocaching query tool written in Ruby
https://buymeacoffee.com/steve8x8
Other
28 stars 8 forks source link

Add locationless (???) waypoints #321

Closed steve8x8 closed 8 years ago

steve8x8 commented 9 years ago

There are hidden waypoints (HTML ishidden="true"), and there are waypoints without coordinates (flagged "???"). At least the latter ones may carry important information one would like to have available (e.g. in c:geo and other apps). They should be visible, and incorporated into waypoint lists. (I have a ruby filter script that can strip them from GPX files.)

I'm not sure whether to classifiy this as Enhancement or Bugfix. Any comments?

steve8x8 commented 9 years ago

It seems to be sufficient the comment out a single line "hidden = true" in the 'no coordinate section' of lib/output.rb, around line 1105. In c:geo, this will result in some mysteries being flagged ("final information available") although the coordinates are zero (but there may be additional text, so one doesn't want to strip them out) Comments?

steve8x8 commented 9 years ago

At least with c:geo, it's currently (tested with 2015-07-16 nightly) possible to use without lat=... and lon=... for waypoints that don't come with predefined coordinates.

steve8x8 commented 9 years ago

I believe all the necessary code changes are now properly in Git. Note that XML validators like SAXCount aren't happy with wpt's lacking lat and lon parameters, but c:geo (at least,up to 2015-07-31 nightly) does import (and correctly interpret) them. Feedback would be appreciated.

steve8x8 commented 8 years ago

Released with 3.24.0.

Leaving this issue open (although considered resolved) for comments and suggestions.

steve8x8 commented 8 years ago

After 3.25.0 release, closing.