search

steve8x8 / geotoad

Geocaching query tool written in Ruby
https://buymeacoffee.com/steve8x8
Other
28 stars 8 forks source link

Favorites count missing #333

Closed SBejga closed 8 years ago

SBejga commented 8 years ago

Hi,

I just noticed that the favorite points count is missing. I only see the fav factor in log created by geotoad (id -2) Neither found in the exported gpx nor in the ruby object. Is it lost due format changes in gc.com? What do you think?

KR, Sebastian

steve8x8 commented 8 years ago

Did you use the last release or git head?

SBejga commented 8 years ago

I have used git head Steve Sixty-Four notifications@github.com schrieb am So., 24. Jan. 2016 um 14:03:

Did you use the last release or git head?

— Reply to this email directly or view it on GitHub https://github.com/steve8x8/geotoad/issues/333#issuecomment-174294588.

steve8x8 commented 8 years ago

Not sure whether I can address this before the upcoming release - TBH I'm surprised someone is actually using fav counts. For now, I blame the "Release 622" changes (for which there's no release notes). May I have your command line for tests?

(Two hours later:) Having run my daily routine in the background, checking my "gpx-cgeo" output, I find (running "grep Fav" over the file)

D/T/S:  3/2.5/regular, Fav: 1.2<br />
    <gsak:FavPoints>1</gsak:FavPoints>
D/T/S:  1.5/1.5/micro, Fav: 1.8&lt;br /&gt;
    <gsak:FavPoints>1</gsak:FavPoints>
D/T/S:  1/1.5/micro, Fav: 0.0&lt;br /&gt;
    <gsak:FavPoints>0</gsak:FavPoints>
D/T/S:  1.5/1.5/micro, Fav: 0.0&lt;br /&gt;
    <gsak:FavPoints>0</gsak:FavPoints>
D/T/S:  1.5/1.5/micro, Fav: 2.5&lt;br /&gt;
    <gsak:FavPoints>2</gsak:FavPoints>

which looks OK to me (not all caches collect fav points). To reproduce your finding, I probably need a full command line (no username/password of course), and have to know whether you're Basic or Premium Member. Sorry for that.

(Yet another edit:) I may have gotten your bug report wrong - standard GPX as defined by http://www.groundspeak.com/cache/1/0/1/cache.xsd does not contain a field for FavPoints, that's a GSAK extension and the specially crafted formats gpx-gsak and gpx-cgeo have it (and apparently fill it correctly).

SBejga commented 8 years ago

Surprised? Searching a bigger radius and then to sort by fav count is great! My "test" command line looks like that: geotoad.rb -U -x gpx -o WID_from_GC2Q17Z_to_GC1GPN8.gpx -m , -q wid GC2Q17Z,GC32MF4,GC1TYN6,GC1GPN8

SBejga commented 8 years ago

Oh, the github mail ended at the pre code thing. So I did not get it when I clicked reply to in the mail client.

I am Premium Member and now a bit confused. I am sure that I have used the favorite count field already in my gpx exports. May I use a wrong command line option?

And no reason for feeling sorry. Geotoad is great and you do a great job!

SBejga commented 8 years ago

Oops. Sorry I am wrong. I was almost sure, that I have used it in that way already. Additionally I added a small debug console log to print the favorites of each fetched cache (directly in the ruby script). And there I got also no field values. At least it would be possible that, gc.com had some problems and was sending malformed html. I do not know. Or I just was tired or misspelled something...

Anyway, it works (again). Sorry for raising an issue.

But I will use the opportunity to thank you for a gread piece of software. It makes my Cacher life a lot of easier ;-)

best regards Sebastian

steve8x8 commented 8 years ago 
WID_from_GC2Q17Z_to_GC1GPN8.cgpx:D/T/S:  1/1/small, Fav: 0.0&lt;br /&gt;
WID_from_GC2Q17Z_to_GC1GPN8.cgpx:    <gsak:FavPoints>9</gsak:FavPoints>
WID_from_GC2Q17Z_to_GC1GPN8.cgpx:D/T/S:  1/2/micro, Fav: 0.0&lt;br /&gt;
WID_from_GC2Q17Z_to_GC1GPN8.cgpx:    <gsak:FavPoints>2</gsak:FavPoints>
WID_from_GC2Q17Z_to_GC1GPN8.cgpx:D/T/S:  1.5/1.5/micro, Fav: 1.2&lt;br /&gt;
WID_from_GC2Q17Z_to_GC1GPN8.cgpx:    <gsak:FavPoints>35</gsak:FavPoints>
WID_from_GC2Q17Z_to_GC1GPN8.cgpx:D/T/S:  2.5/2/regular, Fav: 0&lt;br /&gt;
WID_from_GC2Q17Z_to_GC1GPN8.cgpx:    <gsak:FavPoints>388</gsak:FavPoints>
WID_from_GC2Q17Z_to_GC1GPN8.gpx:D/T/S:  1/1/small, Fav: 0.0&lt;br /&gt;
WID_from_GC2Q17Z_to_GC1GPN8.gpx:D/T/S:  1/2/micro, Fav: 0.0&lt;br /&gt;
WID_from_GC2Q17Z_to_GC1GPN8.gpx:D/T/S:  1.5/1.5/micro, Fav: 1.2&lt;br /&gt;
WID_from_GC2Q17Z_to_GC1GPN8.gpx:D/T/S:  2.5/2/regular, Fav: 0&lt;br /&gt;

Note the "Fav: 0" for the last cache - although I can parse the number of given favpoints from the cache_details page, I have no access to the "icon counters", thus calculating a fav factor doesn't work - this is due to PMO. (There's not even a "Placed Date".) Also note that a fav factor of 0.0 despite a fav count of 2 is due to a large number of visits - the formula is logarithmic, with 5.0 (max) for 100 fp's in 100 logs, about 2.5 for 10 in 100 (10 logs give you one fav point to spend as PM), and down to zero for 1 in 100 or even less.