search

steve8x8 / geotoad

Geocaching query tool written in Ruby
https://buymeacoffee.com/steve8x8
Other
28 stars 8 forks source link

Error in parseCache():data.split after Feb 2016 site updates #334

Closed steve8x8 closed 8 years ago

steve8x8 commented 8 years ago

In a WID search, to get hold of all Wherigos in the area:

* Error in parseCache():data.split * WID affected: GC67MJV /.../lib/details.rb:359:in block in parseCache': undefined methodkey?' for nil:NilClass (NoMethodError)

It turns out that a spurious match in the comment section caused the WID to be overwritten. The patch attached 334-key.diff.txt fixes this; side-effects are to be investigated.

steve8x8 commented 8 years ago

Since there are side-effects under certain circumstances, it's better not to completely drop the pattern but to restrict overwriting existing wid values. 334-key.diff.txt is the latest approach at this. Feedback welcome!

steve8x8 commented 8 years ago

The ultimate () solution seems to be: if there's a cachepmo.aspx link/form, it's certainly a PMO cache and there are almost no other ways to get hold of the WID. The more generic cache.aspx pattern can only serve as an emergency brake. I'll commit a corresponding change when more tests have succeeded (this might even become a bugfix release, depending on hardware access). (*) There's no ultimate solution as there's no ultimate server-side software release.

steve8x8 commented 8 years ago

This should be merged with Issue #332