search

steve8x8 / geotoad

Geocaching query tool written in Ruby
https://buymeacoffee.com/steve8x8
Other
28 stars 8 forks source link

GeoToad (3.29.1 and before) randomly reuses text for additional waypoints #364

Closed steve8x8 closed 4 years ago

steve8x8 commented 5 years ago

Sometimes, GeoToad does not extract the proper "Note" text from the Additional Waypoints table, and uses the one of the previous entry instead - this can happen multiple times in a row for the same cache (example: GC6GHP4; instructions for some virtual waypoint tasks are missing from the GPX output - fortunately they are repeated in the long description).

Reloading the cache details within c:geo (of course) recitifies the problem, but (of course) that completely misses the point of running GeoToad before.

steve8x8 commented 5 years ago

It turns out that the failed waypoint notes contain line breaks instead of <br> tags.

steve8x8 commented 5 years ago

Further investigation shows that this bug must have been present for almost nine years. Additional Waypoints handling was extended in Oct/Nov 2010 between versions 3.12.1 and 3.13.0, and it's hard to believe that nobody hit it before. A fix is being worked on, extensive testing is required.

steve8x8 commented 5 years ago

Patches have been committed. Testers are welcome, as always. (There's still WiP, trying to minimise the effect of some previous changes.)

steve8x8 commented 4 years ago

Fixed in 3.29.2, closing.