steve8x8 / geotoad

Geocaching query tool written in Ruby
https://buymeacoffee.com/steve8x8
Other
28 stars 8 forks source link

replace URI.escape for compatibility with ruby 3.0 #367

Closed freswa closed 1 year ago

freswa commented 3 years ago

URI.escape did a lot of magic to differentiate between URL components to escape them differently. Since we only need to escape a query to use in a map http link, we use the encode_www_form_component function here.

fixes #366

JP95Git commented 2 years ago

This works for me. Thanks.

steve8x8 commented 1 year ago

Thanks for contributing, I found it safer to have a fallback between the two approaches... This has been addressed by https://github.com/steve8x8/geotoad/commit/15fa295ca4562d0a3ae66f14febab5894ac0c089 and will be released with https://github.com/steve8x8/geotoad/milestone/14