steveandroulakis / mytardis-lighthouse-migrate-test

testing migrations from http://mytardis.lighthouseapp.com/ to Github Issues
0 stars 0 forks source link

Single Search Fails on '_' in ParameterNames #83

Open steveandroulakis opened 11 years ago

steveandroulakis commented 11 years ago

For instance, in the creative commons schema there exists the name (machine name) 'license_name', which displays in the solr schema.xml as

<field name="experiment_creative_commons_license_license_name" type="text" indexed="true" stored="true" multiValued="false" />

and returns this error on re-indexing:

Unhandled exception in thread started by <bound method Thread.__bootstrap of <Thread(Thread-1, stopped daemon -1211913328)>>

Resulting in the index not being updated at all.

While currently not 'the norm', underscores in parameter names is technically not illegal. So I suggest they be handled correctly (probably, hopefully, just an extra 'if' statement before a string replace or some such).

As an aside, all parameter names with multiple words used to be underscored instead of camelCased because xml elements use underscores as standard practice and at the time we were mainly concerned with METS XML ingest to MyTardis. Somewhere in the mix they were changed, for whatever reason.

original LH ticket

This ticket has 0 attachment(s).

steveandroulakis commented 11 years ago

Single Search Fails on ’_’ in ParameterNames

How’d you come to the conclusion that it’s the underscores causing the problem? We’ve got heaps of schemas parameter fields with underscores appearing just fine at the AS. Do you have any logging etc. you can show me of the problem or is it just a massive totally silent failure?

by shaunokeefe

steveandroulakis commented 11 years ago

Single Search Fails on ’_’ in ParameterNames

Ah, good to know.. silent except for that re-indexing error aaaand:

Indexing 12 dataset_ files. Exception in thread Thread-1 (most likely raised during interpreter shutdown): Traceback (most recent call last): File "/opt/python2.7/lib/python2.7/threading.py", line 530, in __bootstrap_inner File "/opt/python2.7/lib/python2.7/threading.py", line 483, in run File "/opt/python2.7/lib/python2.7/multiprocessing/pool.py", line 272, in _handle_workers <type 'exceptions.TypeError'>: 'NoneType' object is not callable

I removed the underscore as a test and the schema shows:

<field name="experiment_creative_commons_license_license_name" type="text" indexed="true" stored="true" multiValued="false" />

And it still fails! So something’s up with this particular parameter name but it isn’t the underscore? What is it!?

by Steve Androulakis

steveandroulakis commented 11 years ago

Single Search Fails on ’_’ in ParameterNames

If you’re superkeen, you can grab this 2gb+ VM and load it in VirtualBox, and try ~/mytardis/bin/update_solr_schema.sh and tail -f ~/mytardis/log/solr-indexing.log

username: root password: mytardis

http://squirrel.its.monash.edu.au/download/datafile/17747/

by Steve Androulakis

steveandroulakis commented 11 years ago

Single Search Fails on ’_’ in ParameterNames

If I download that, I won’t have quota for my torrentz!!!

by shaunokeefe

steveandroulakis commented 11 years ago

Single Search Fails on ’_’ in ParameterNames

Do eeeet!

by Steve Androulakis

steveandroulakis commented 11 years ago

Single Search Fails on ’_’ in ParameterNames

Busy...fixing...other...stuff...

by shaunokeefe

steveandroulakis commented 11 years ago

Single Search Fails on ’_’ in ParameterNames

It’s cool! It’s not a ’2.5’ thing. So just noting it down and having a WTF :)

by Steve Androulakis