search

stevearc / dressing.nvim

Neovim plugin to improve the default vim.ui interfaces
MIT License
1.73k stars 32 forks source link

Close input on <Esc> #1

Closed bsander closed 2 years ago

bsander commented 2 years ago

This plugin looks great! I have a hard time canceling a rename operation though, pressing Escape just changes to normal mode but doesn't close the rename input modal. Seems like I need to explicitly close the window for that. Am I missing something? I think pressing Escape should close the window and cancel the renaming.

mel10c commented 2 years ago

Yeah, seems that this problem is only present for the input section, the selection section would work exist properly with the Escape button.

stevearc commented 2 years ago

Sounds like a good idea to me!

axieax commented 2 years ago

Hello, not sure but can anyone else reproduce this issue? I'm trying to use vim.lsp.buf.rename.

https://user-images.githubusercontent.com/62098008/144731851-4ef3cd39-91cf-430b-a1ea-377f990aa95d.mp4

stevearc commented 2 years ago

Apologies, should be fixed now. I was using a :command mapping instead of <cmd> to force the completion window to close (if it was visible), but that caused this issue. Refactored it to close the window in a more reliable way.