extension rename is not working

[kryshac]

Describe the bug after I installed the extension, rename from lsp (angularls) no longer works, I receive this message: Language server couldn't provide rename result

System information

• OS: linux
• Neovim version: NVIM v0.9.5
• Dressing config:

{
  'stevearc/dressing.nvim',
  opts = {
    input = {
      insert_only = false,
      relative = 'editor',
    },
  },
}

To Reproduce Steps to reproduce the behavior:

https://github.com/stevearc/dressing.nvim/assets/19764133/f375676b-26ea-465a-877f-dd2a91594364

if you need some logs tell me which ones. Thanks

[stevearc]

I notice that after you close the rename dialog your cursor has moved to the beginning of the line, which would cause the LSP client to not know what variable to rename (it looks for the one under the cursor). Can you reproduce this cursor-jumping behavior with a minimal example? An easy way to do this would be to make a file with this contents

-- test.lua
vim.ui.input({}, function() end)

edit it and then run :source.

It would also help if you can do this with a minimal init.lua to eliminate confounding factors from your other plugins.

-- save as repro.lua
-- run with nvim -u repro.lua
-- DO NOT change the paths
local root = vim.fn.fnamemodify("./.repro", ":p")

-- set stdpaths to use .repro
for _, name in ipairs({ "config", "data", "state", "runtime", "cache" }) do
    vim.env[("XDG_%s_HOME"):format(name:upper())] = root .. "/" .. name
end

-- bootstrap lazy
local lazypath = root .. "/plugins/lazy.nvim"
if not vim.loop.fs_stat(lazypath) then
    vim.fn.system({
        "git",
        "clone",
        "--filter=blob:none",
        "--single-branch",
        "https://github.com/folke/lazy.nvim.git",
        lazypath,
    })
end
vim.opt.runtimepath:prepend(lazypath)

-- install plugins
local plugins = {
    "folke/tokyonight.nvim",
    {
        "stevearc/dressing.nvim",
        config = function()
            require("dressing").setup({})
        end,
    },
}

require("lazy").setup(plugins, {
    root = root .. "/plugins",
})

vim.cmd.colorscheme("tokyonight")

[kryshac]

if I do this, the cursor stays where it should be

[kryshac]

what I noticed is that it renames the position where the cursor was last time in insert mode:

https://github.com/stevearc/dressing.nvim/assets/19764133/99b8f129-6ae0-4fb3-9034-1590051f306a

[dk949]

FWIW I had a similar issue because I have the following in my init.lua:

vim.api.nvim_create_autocmd("BufWritePre", {
    pattern = "*",
    command = [[mkview]],
})
vim.api.nvim_create_autocmd("BufEnter", {
    pattern = "*",
    command = [[silent! loadview]],
})

So the code buffer got reset to the last saved view when returning from the input window. The band-aid solution was to just add a vim.cmd[[mkview]] to my rename shortcut.

This may be entirely irrelevant to your case, but the behaviour is very similar.

[kryshac]

@dk949 you're right. If I deactivate the 'Save View for Fold' feature, the plugin issue is resolved.

I have this

-- auto save fold view after exit a file
vim.api.nvim_create_autocmd({ 'BufLeave', 'BufWinLeave', 'InsertLeave' }, {
  pattern = { '*.*' },
  desc = 'save view (folds), when closing file',
  command = 'mkview',
})

-- auto load fold view after enter a file
vim.api.nvim_create_autocmd({ 'BufRead', 'BufWinEnter', 'BufEnter' }, {
  pattern = { '*.*' },
  desc = 'load view (folds), when opening file',
  command = 'silent! loadview',
})

but if I don't use dressing.nvim then there is no conflict with `mkview'

[dk949]

but if I don't use dressing.nvim then there is no conflict with `mkview'

It's because the default implementation does not open a new window, it just puts you in command mode, so when the input dialog is closed there is no BufEnter event and the loadview command isn't executed.