search

stevearc / dressing.nvim

Neovim plugin to improve the default vim.ui interfaces
MIT License
1.73k stars 32 forks source link

Feature Request: Extend the plugin for `vim.notify()` and `vim.notify_once()` #23

Closed rgnkn closed 1 year ago

rgnkn commented 2 years ago

I'd like to suggest that dressing.nvim extends is functionality to vim.notify() and vim.notify_once() calls.

stevearc commented 2 years ago

Have you checked out nvim-notify? I think they do a fantastic job of providing a nice UI on top of vim.notify.

rgnkn commented 2 years ago

I know and used it for a while but had some minor issues with it - dependend on my configuration.

Currently I use my own hacked in solution for it, but the "nature" is quite similar to that of dressing selects and I think it would be easy for dressing.nvim to hook into vim.notify() as it does with vim.ui.select() and vim.ui.input().

If you don't like this idea you can close this Feature Request. If you're interest but don't have the time to deal with this I might be able to make you a PR up this weekend or so.

stevearc commented 2 years ago

In general I'm opposed to fragmentation, but I think it's warranted in a few situations. Telescope and fzf, for example. Telescope is trying to be the best picker interface for Neovim, and fzf is trying to integrate the fzf command line tool into vim for common picking tasks. They do a lot of the same thing, but they both have value for their different approaches and probably shouldn't exist within the same repo.

So I'm curious what your solution for vim.notify is, and if it's philosophically different enough from nvim-notify to warrant a separate implementation? There's also the question of if that tool should be included in dressing.nvim or if it would make more sense to be published on its own.