Closed richard-gebbia closed 3 years ago
The change looks great! To test it and make sure it's working I'd recommend either adding a new case in test_parser.py
or simply adding some groups to this last test case:
Tests are currently failing because of lint. It looks like black
was updated to have some different formatting preferences. You can apply those changes by running tox -e format
.
Thank you for the direction! I've done the formatting and added some test code to cover my additions. Please let me know if there's anything else I need to do.
Thanks for the submission!
Hi!
First of all thank you so much for making this project! It's so far saved me quite a bit of time on my own Godot project.
However, my project requires that the nodes that I'm generating have groups (this is normally done in Godot by manually assigning a node to a group in the inspector). It looks like groups was on your todo-list based on the code comments, so I tried my best to implement them. Implementing these changes locally has allowed me to export nodes with groups.
I'm relatively new to Python development and I wasn't sure how to test my changes, so please let me know if this is an acceptable change, and if it's not I would appreciate some direction to make it so.