stevearc / oil.nvim

Neovim file explorer: edit your filesystem like a buffer
MIT License
3.84k stars 110 forks source link

bug: preview window stays open if you leave Oil buffer with :edit #295

Closed lucaseras closed 7 months ago

lucaseras commented 8 months ago

Did you check the docs and existing issues?

Neovim version (nvim -v)

NVIM v0.9.5

Operating system/version

MacOS 14.3

Describe the bug

With the preview window open, editing a non-oil file without selecting it via Oil (e.g. via :edit) does not close the preview window. So you are now editing a non-Oil buffer with the preview window still open

What is the severity of this bug?

minor (annoyance)

Steps To Reproduce

  1. nvim -u repro.lua
  2. :Oil
  3. <C-p> to open preview window
  4. :e baz.txt to edit file

Expected Behavior

Preview window should close since we are not in an oil buffer anymore

Directory structure

a/foo.txt baz.txt

Repro

-- save as repro.lua
-- run with nvim -u repro.lua
-- DO NOT change the paths
local root = vim.fn.fnamemodify("./.repro", ":p")

-- set stdpaths to use .repro
for _, name in ipairs({ "config", "data", "state", "runtime", "cache" }) do
  vim.env[("XDG_%s_HOME"):format(name:upper())] = root .. "/" .. name
end

-- bootstrap lazy
local lazypath = root .. "/plugins/lazy.nvim"
if not vim.loop.fs_stat(lazypath) then
  vim.fn.system({
    "git",
    "clone",
    "--filter=blob:none",
    "--single-branch",
    "https://github.com/folke/lazy.nvim.git",
    lazypath,
  })
end
vim.opt.runtimepath:prepend(lazypath)

-- install plugins
local plugins = {
  "folke/tokyonight.nvim",
  {
        "stevearc/oil.nvim",
        config = function()
            require("oil").setup({
              -- add any needed settings here
            })
        end,
  },
  -- add any other plugins here
}
require("lazy").setup(plugins, {
  root = root .. "/plugins",
})

vim.cmd.colorscheme("tokyonight")
-- add anything else here

Did you check the bug with a clean config?