stevearc / oil.nvim

Neovim file explorer: edit your filesystem like a buffer
MIT License
3.36k stars 91 forks source link

feat: improve is_modifiable checks for unix os's #428

Closed DerpDays closed 2 weeks ago

DerpDays commented 2 weeks ago

About

This will resolve #342, it improves the is_modifiable function for directories on unix systems by more accurately checking whether the user has write permission for the directory.

This PR changes the function so that it:

Questions

stevearc commented 2 weeks ago

I refactored the caching logic a bit because we didn't need it to be as fancy. LMK if this looks good to you and I'll merge

DerpDays commented 2 weeks ago

Looks good to me! I had kept it in the cache utility since I wasn't sure on how you'd want it, but this way is a lot easier to follow and nicer!