stevearc / pypicloud-docker

Docker image for pypicloud
MIT License
86 stars 34 forks source link

Make uwsgi shell script executable for my_init #22

Closed amorriscode closed 6 years ago

amorriscode commented 6 years ago

I was trying to run the py3-baseimage Dockerfile and noticed that the pypicloud-uwsgi.sh script was not running. After digging into the my_init script, I noticed that it checks if files inside of /etc/my_init.d are executable. If they are, it runs them. I added a chmod +x to the Dockerfile and then the script ran as expected.

stevearc commented 6 years ago

What tag specifically are you using? When I look at the most recent images they look fine

+08:34:36 stevearc@prime~:$ docker pull stevearc/pypicloud > /dev/null
+08:34:45 stevearc@prime~:$ docker run --rm -it stevearc/pypicloud:1.0-py3-baseimage /bin/bash
root@786293e3449a:/# ls -l etc/my_init.d
total 12
-rwxr-xr-x 1 root root 263 Jan 26  2018 00_regen_ssh_host_keys.sh
-rwxr-xr-x 1 root root 857 Jan 26  2018 10_syslog-ng.init
-rwxr-xr-x 1 root root 202 Sep  6 15:58 pypicloud-uwsgi.sh
amorriscode commented 6 years ago

Yeah, I actually copied your file to my computer and tried to build/run it locally. I can look into it further but we can close this PR if you'd like. 😄

stevearc commented 6 years ago

Yeah, it sounds like there may have been an issue either with git not setting the correct file permissions on the checkout or perhaps your version of docker wasn't copying the permissions correctly. Or maybe it has something to do with the filesystem you're on ¯\(ツ)/¯