stevearc / pypicloud-docker

Docker image for pypicloud
MIT License
86 stars 34 forks source link

Add multi-arch support to build.sh #37

Closed ddelange closed 2 years ago

ddelange commented 2 years ago

Will additionally push armv8 (arm64) and armv7 (32bit) docker images to dockerhub when a github release is (pre)released, or manually from the Actions tab after pushing a tag (but not releasing it as github release).

The script can still be used locally with a recent docker version that comes with buildx, also without QEMU emulator installed, to build and push the AMD image only (the default if BUILDX_PLATFORMS env var is not set)

pushing multi-arch manifest separately from the build command like it was is iffy (regctl needed), so just running build command again but with --push, which should be minimal overhead.

stevearc commented 2 years ago

LGTM, thanks for the PR