Expanded Exec Command Options

rhpot1991 commented 7 years ago

Added InsertHTML support for IE and insertFontPoint for all browsers.

codewithtyler commented 7 years ago

Can you run jshint? The project is currently set up to use the Google style guide and I noticed that you removed the space from between the parenthesis. Running jshint should take care of that.

spreadred commented 7 years ago

Merging this PR results in (when clicking any toolbar button):

Uncaught TypeError: Cannot read property 'indexOf' of undefined
    at HTMLAnchorElement.<anonymous> (bootstrap-wysiwyg.js:296)
    at HTMLAnchorElement.dispatch (jquery.min.js:3)
    at HTMLAnchorElement.r.handle (jquery.min.js:3)
(anonymous) @ bootstrap-wysiwyg.js:296
dispatch @ jquery.min.js:3
r.handle @ jquery.min.js:3

It refers to this line: else if ( editor.data( options.commandRole ).indexOf( 'fontPoint' ) >= 0 )

EDIT: this has been fixed and pushed to my fork. If you want to cherry-pick the commit, the hash is e8cdd750bc3de40ebdaee23f3224a769b502a39b

steveathon commented 6 years ago

@rhpot1991 can you pickup the changes that @kaptainkommie made for your fork so we can close off this PR?

steveathon commented 6 years ago

Bump @rhpot1991 ?

steveathon / bootstrap-wysiwyg

Expanded Exec Command Options #111