steveathon / bootstrap-wysiwyg

Tiny bootstrap-compatible WYSIWYG rich text editor
MIT License
661 stars 1.71k forks source link

bootstrap-wysiwyg.min.js missing a final semicolon; causing cascaded script failures. #32

Closed durangosw closed 9 years ago

durangosw commented 9 years ago

The missing semicolon is causing all following scripts to fail.

It stands to reason this will also cause problems if sourcing the scripts in a web page, but have only tested the gulp mix.

Steps to Reproduce

  1. Create a gulp mix.scripts command.
  2. Prepend bootstrap-wysiwyg.min.js to the array of scripts to combine.
  3. Run gulp.
  4. View importing web page in chrome, and then open chrom dev tools to see errors.

Workarounds (successful ones are marked with an 'x'):

codewithtyler commented 9 years ago

In my current PR #25 I used Gulp to lint and minify the bootstrap-wysiwyg.js file. Once that PR has been merged it should fix your issue.

codewithtyler commented 9 years ago

FYI there were multiple missing semicolons.

durangosw commented 9 years ago

Thanks in advance!

codewithtyler commented 9 years ago

@steveathon this can be closed now