search

steveathon / bootstrap-wysiwyg

Tiny bootstrap-compatible WYSIWYG rich text editor
MIT License
661 stars 1.71k forks source link

Added max file size #64

Closed ezekieltanch closed 7 years ago

ezekieltanch commented 8 years ago

Added max file size to prevent time-out caused by large images

codewithtyler commented 8 years ago

Is 1MB the maximum file size that the editor will take without timing out?

steveathon commented 8 years ago

What part is timing out? Images preview on the client side using client memory and resources. Can you give me a sample page that we can reference to test this out?

Submission limitations to a backend server really shouldn't be a part of the WYSIWYG, but this library should pass responsibility of that action to a different process.

steveathon commented 8 years ago

@ezekieltanch any chance you can update me on this one? Curious about if it's failing for reasons we can fix, or reasons we can't control.

codewithtyler commented 8 years ago

@steveathon I tested the drag and drop feature using 1.27 MB and 3.68 MB images and both uploaded with no problem. Unfortunately, we currently have a bug where the Insert Image button fails to open the file picker window so I have been unable to test using this method.

steveathon commented 8 years ago

I think, (that bug aside) we should close this. I don't think setting upload limits by default is required. If anything, I'd only want to see upload limits as a configurable option if the user decided it was the best for their particular use case.

steveathon commented 7 years ago

I'm declining this PR due to it not being a core requirement of the editor.