search

steveathon / bootstrap-wysiwyg

Tiny bootstrap-compatible WYSIWYG rich text editor
MIT License
663 stars 1.7k forks source link

Don't trash placeholder text when initialising #96

Closed pugnascotia closed 8 years ago

pugnascotia commented 8 years ago

I found that if I had a div with a "placeholder" attribute that already contained text, then the content was being trashed. Change the code not to do this!

Also change package.json to list bower and to run bower install as a postinstall.

codewithtyler commented 8 years ago

@RoryHunter can you explain what "build: "gulp" does in the package.json?

pugnascotia commented 8 years ago

@RandomlyKnighted That just lets me use npm run build to execute gulp, since I don't have it globally installed. Hope you don't mind.

codewithtyler commented 8 years ago

Would this work with Grunt as well if you had "build": "grunt"?

pugnascotia commented 8 years ago

Yes - npm will find anything in ./node_modules/.bin/ and you can reference it in a scripts entry.

codewithtyler commented 8 years ago

Interesting, thanks for the clarification. FYI, in a future PR this will change to utilize Grunt over Gulp. However, this is fine for the time being. Thank you for your contribution!