search

stevebauman / location

Detect a users location by their IP Address.
MIT License
1.1k stars 177 forks source link

Add IP2Location.io Driver #150

Closed ip2location closed 11 months ago

ip2location commented 1 year ago

Related to #147 .

ip2location commented 12 months ago

Hi @stevebauman ,

May I check what is the progress now?

stevebauman commented 11 months ago

Sorry for the late review on this @ip2location! Looks good to me, thanks for your contribution!

The test added in this PR is failing, can you fix it? Once fixed, I'll merge and deploy a new version 👍

ip2location commented 11 months ago

Sorry for the late review on this @ip2location! Looks good to me, thanks for your contribution!

The test added in this PR is failing, can you fix it? Once fixed, I'll merge and deploy a new version 👍

Hi @stevebauman,

I have checked the error message, but looks like it is failing on Maxmind's driver, I'm not sure what I can do from my side.

stevebauman commented 11 months ago

Screenshot 2023-11-21 at 7 32 09 PM

ip2location commented 11 months ago

Screenshot 2023-11-21 at 7 32 09 PM

Hi @stevebauman ,

I didn't noticed this on yesterday. I have pushed new fix for the failing test and the test case is passed on my side.

stevebauman commented 11 months ago

No worries, thanks for fixing it! 🙏