Closed ip2location closed 11 months ago
Hi @stevebauman ,
May I check what is the progress now?
Sorry for the late review on this @ip2location! Looks good to me, thanks for your contribution!
The test added in this PR is failing, can you fix it? Once fixed, I'll merge and deploy a new version 👍
Sorry for the late review on this @ip2location! Looks good to me, thanks for your contribution!
The test added in this PR is failing, can you fix it? Once fixed, I'll merge and deploy a new version 👍
Hi @stevebauman,
I have checked the error message, but looks like it is failing on Maxmind's driver, I'm not sure what I can do from my side.
Hi @stevebauman ,
I didn't noticed this on yesterday. I have pushed new fix for the failing test and the test case is passed on my side.
No worries, thanks for fixing it! 🙏
Related to #147 .