search

stevebauman / unfinalize

Remove "final" keywords from classes and methods in vendor packages.
MIT License
135 stars 5 forks source link

A few improvements... #2

Closed aidan-casey closed 1 year ago

aidan-casey commented 1 year ago

Hey there!

I hope you are doing well. I stumbled across this unfinalize package and noticed a few areas for improvement so I wanted to help the community and create a PR.

Feel free to review and merge when you're ready to embrace the final frontier of coding perfection!

Yours in finality, Aidan

stevebauman commented 1 year ago

Thanks @aidan-casey! This is a 🔥 PR and I appreciate your time, but I simply cannot humbly accept such an improvement ❤️

aidan-casey commented 1 year ago

Thanks for taking the time to review, @stevebauman! While I respect your stance, I have to admit it is a little disappointing. This is your final decision?

stevebauman commented 1 year ago

No problem @aidan-casey! No nothing is ever final. Once the keyword allows inheritance, I'll merge this PR 👍

Wirone commented 1 year ago

@stevebauman can't you just bypass it while reading?