search

steveberardi / starplot

✨ Star charts and maps in Python
https://starplot.dev
MIT License
17 stars 7 forks source link

v0.9.0 #57

Closed steveberardi closed 3 months ago

steveberardi commented 4 months ago

Summary

Preview

pip install starplot==0.9.0b1

Docs ➡️ https://archives.starplot.dev/0.9.0b/

steveberardi commented 4 months ago

@EsatAkkasoglu - I'm getting ready to release the next version of Starplot, and there's some big changes, so I'd greatly appreciate any thoughts or concerns you have with the changes in this PR cause I know you're actively using Starplot for a project -- there's a pre-release version on PyPI (starplot==0.9.0b) if you wanna check it out. Thanks!!

bathoorn commented 3 months ago

Hi Steve

I will then pull in the latest commits from the v0.9.0 branch.

I have done some work on printing a planisphere calendar ring but I don't think it will be ready in time. But I can do that for the next release.

I also did some work on not printing things that are not visible. So will check if that fits in with your latest changes.

Kind regards, Ronnie

On Mon, 4 Mar 2024, 15:02 Steve Berardi, @.***> wrote:

@EsatAkkasoglu https://github.com/EsatAkkasoglu - I'm getting ready to release the next version of Starplot, and there's some big changes, so I'd greatly appreciate any thoughts or concerns you have with the changes in this PR cause I know you're actively using Starplot for a project -- there's a pre-release version on PyPI (starplot==0.9.0b) if you wanna check it out. Thanks!!

— Reply to this email directly, view it on GitHub https://github.com/steveberardi/starplot/pull/57#issuecomment-1976648011, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAFZWJ3GT54KRCP4VOAPTULYWR5GXAVCNFSM6AAAAABEEM3CLCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNZWGY2DQMBRGE . You are receiving this because you were mentioned.Message ID: @.***>

steveberardi commented 3 months ago

I have done some work on printing a planisphere calendar ring but I don't think it will be ready in time. But I can do that for the next release.

that'd be awesome 👍 I'm planning to work a lot on label issues for v0.10.0 so the calendar ring for zenith plots would fit in well :)

steveberardi commented 3 months ago

@bathoorn when I merged this PR last night, I was hoping it would've added you as a "Contributor" on the GH repository page, but it didn't 😞 I'm guessing cause I did a "Squash & Merge" -- GH did add you as a contributor on the release page though 🤔

Anyway, I apologize. I greatly appreciate the contribution you made for this release, so just wanted to make sure you were recognized on the repo. If you want, I think you could open a PR to main from your fork and when I merge that it'll add you as a contributor. You could just add an empty file or comment or something in the PR.

bathoorn commented 3 months ago

No worries, thanks for the heads up!

And my plan is to work on the calendar ring for the planisphere. So there will be other contributions where we can get it to work :)

On Wed, 13 Mar 2024, 15:23 Steve Berardi, @.***> wrote:

@bathoorn https://github.com/bathoorn when I merged this PR last night, I was hoping it would've added you as a "Contributor" on the GH repository page, but it didn't 😞 I'm guessing cause I did a "Squash & Merge" -- GH did add you as a contributor on the release page though 🤔

Anyway, I apologize. I greatly appreciate the contribution you made for this release, so just wanted to make sure you were recognized on the repo. If you want, I think you could open a PR to main from your fork and when I merge that it'll add you as a contributor. You could just add an empty file or comment or something in the PR.

— Reply to this email directly, view it on GitHub https://github.com/steveberardi/starplot/pull/57#issuecomment-1994522648, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAFZWJZFNXJ5ARO7XTQX7SLYYBOOPAVCNFSM6AAAAABEEM3CLCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSOJUGUZDENRUHA . You are receiving this because you were mentioned.Message ID: @.***>

steveberardi commented 3 months ago

@bathoorn sounds good, thanks so much for your understanding!