steveblue / angular2-rollup

CLI for bundling Angular with Rollup and Closure Compiler
121 stars 18 forks source link

NGR ERROR ReferenceError: rej is not defined #32

Closed danielpcampagna closed 5 years ago

danielpcampagna commented 5 years ago

Prerequisites

> yarn --version
1.12.3

> ng --version
Angular CLI: 7.1.3
Node: 11.3.0
OS: win32 x64
Angular: 7.1.3

> ngr --version
2.0.1

Current Behavior

On build application using JIT compiler I get this error:

> ngr build jit
NGR ERROR ReferenceError: rej is not defined
    at ReadFileContext.fs.readFile [as callback] (C:\Users\MyUser\AppData\Roaming\npm\node_modules\angular-rollup\src\compile\tsc.js:93:21)
    at FSReqCallback.readFileAfterOpen [as oncomplete] (fs.js:245:13)

Inspecting that file, function rej is not defined. I suppose that enough passes it as the argument to promise. https://github.com/steveblue/angular2-rollup/blob/33a791058097144f6b2c5dfe39d29ea6a0be07ad/src/compile/tsc.js#L58-L99

Steps to Reproduce

  1. Create a new project and install dependencies
> ngr new my-app --yarn
> yarn install
  1. Generate dist files using JIT Compiler.
> ngr build jit
NGR ERROR ReferenceError: rej is not defined
    at ReadFileContext.fs.readFile [as callback] (C:\Users\MyUser\AppData\Roaming\npm\node_modules\angular-rollup\src\compile\tsc.js:93:21)
    at FSReqCallback.readFileAfterOpen [as oncomplete] (fs.js:245:13)
steveblue commented 5 years ago

Was this the only issue blocking jit @danielpcampagna ? Kinda amazing if it is because I haven't been supporting the jit build in a couple months.

danielpcampagna commented 5 years ago

Actually, I was just trying to use this feature. So, this is all that I know. :/