stevecochrane / tailwindcss-logical

A CSS Logical Properties and Values plugin for Tailwind CSS.
https://stevecochrane.github.io/tailwindcss-logical/
ISC License
172 stars 2 forks source link

make the demo page more prominent in README #23

Closed sa3dany closed 2 years ago

sa3dany commented 2 years ago

I never noticed there was a demo until I saw the release notes for v1.4.0 which were about the demo improvements. I also suggest adding it as the repo website (About ⚙ > Website.)

Thanks for making this plugin! I really believe it is the way forward for proper RTL support in tailwindcss and with the introduction of JIT I hope tailwindlabs add all these utilities to core based on your plugin.

codecov-commenter commented 2 years ago

Codecov Report

Merging #23 (202c29b) into master (924bc4c) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master       #23   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            2         2           
  Lines          390       390           
  Branches        41        41           
=========================================
  Hits           390       390           

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 924bc4c...202c29b. Read the comment docs.

stevecochrane commented 2 years ago

These are great suggestions, thank you very much for taking the time to do this! I don't hear from people using this plugin very often, so it means a lot to me. I'm glad this is useful for you.

And yes, I agree that it would be great to have Logical Properties and Values integrated with Tailwind itself, and with JIT mode freeing them up from file size concerns (and with browser support also continuing to improve) I think it makes a lot of sense. Hopefully that's something we'll see soon.