Join forks code into (this) main repo

stevefolta / SFZero

A simple SFZ player plugin

MIT License

90 stars 32 forks source link

Join forks code into (this) main repo #3

Open falkTX opened 6 years ago

falkTX commented 6 years ago

There are currently 2 forks of SFZero which provide useful new features. https://github.com/schellingb/SFZero https://github.com/jamiebullock/SFZero

Would be nice to get everything together in 1 repo, so we don't have to choose between features.

I would rather submit bugs against the forks, to request a PR from them, but they have closed the reporting of bugs :(

falkTX commented 6 years ago

Will you accept a PR that incorporates the useful changes from those repos? I could do this, eventually...

simonvanderveldt commented 6 years ago

It might be useful to ping @schellingb and @jamiebullock for this?

jamiebullock commented 6 years ago

@falkTX @simonvanderveldt Sorry, I've only just seen this, for some reason I missed the notification.

I think merging forks would be a good idea, but it needs some care. I'm also not sure if @stevefolta is interested in continuing to work on this, review and merge PRs etc. It might be better if one of the downstream repos became the official one.

Anyhow, I've opened the issue tracker on my fork if you want to report bugs there.