Replaced jQuery with $ to work with UMD wrapper

stevegreatrex / ko.plus

Awesome extensions to KnockoutJS

http://stevegreatrex.github.io/ko.plus

MIT License

34 stars 12 forks source link

Replaced jQuery with $ to work with UMD wrapper #27

Closed SimmeNilsson closed 6 years ago

SimmeNilsson commented 6 years ago

UMD wrapper for ko.plus library exposes jQuery as $ for the parts. But for sortable part jQuery is still passed into the IIFE which makes it look globally for jQuery variable instead of using parameter $. This pull request addresses that, (but if sortable is used as a separate file and $ is not set on window then might break).

SimmeNilsson commented 6 years ago

Thanks! Would it be possible to update the npm package?

stevegreatrex commented 6 years ago

All done - 0.0.32 is up now. Enjoy!

On Mon, 16 Jul 2018 at 09:52, SimmeNilsson notifications@github.com wrote:

Thanks! Would it be possible to update the npm package?

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/stevegreatrex/ko.plus/pull/27#issuecomment-405183863, or mute the thread https://github.com/notifications/unsubscribe-auth/AA0J0OMW7buu_LYR_qzhq3cEIj-ydUC5ks5uHFRLgaJpZM4U5rlI .