search

stevegrunwell / lost-in-translation

Uncover missing translations and localization strings in Laravel applications.
https://stevegrunwell.com/blog/find-missing-laravel-translations/
MIT License
36 stars 8 forks source link

Translations with replaced keys did not trigger a MissingTranslationException #13

Closed batrol closed 4 years ago

batrol commented 4 years ago

Ex: Translated Keys: "strike_number_1" : "Strike One"

Key not translated and not flagged $strikes = 1; ('He makes contact with the ball, but not enough to get a hit. Foul tip. :strike_number.', [ 'strike_number' => ('strikenumber' + $strikes) ]);

The current check will compare "He makes contact with the ball, but not enough to get a hit. Foul tip. :strike_number." with "He makes contact with the ball, but not enough to get a hit. Foul tip. Strike One" and it will not flag the key as not translated.

coveralls commented 4 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling fb007e352c93f4ce6d76efaf032be11441191c65 on batrol:develop into 3fc3b87b1410f738767672fc210fd20214a65f6f on stevegrunwell:develop.

stevegrunwell commented 4 years ago

Hey @batrol, this looks great, thank you!

batrol commented 4 years ago

Hey Steve. Thank you for the amazing work. Happy to contribute =)

*--*Plínio Almeida de Oliveira

Em qua., 29 de jul. de 2020 às 22:12, Steve Grunwell < notifications@github.com> escreveu:

Hey @batrol https://github.com/batrol, this looks great, thank you!

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/stevegrunwell/lost-in-translation/pull/13#issuecomment-665901715, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAUMM5X2CY4AGSEWMDIKWI3R6B7EJANCNFSM4PIGXUZA .