search

stevegrunwell / lost-in-translation

Uncover missing translations and localization strings in Laravel applications.
https://stevegrunwell.com/blog/find-missing-laravel-translations/
MIT License
36 stars 8 forks source link

Fixed tests and updated composer. #7

Closed Lednerb closed 5 years ago

Lednerb commented 5 years ago

This should fix the issues with #5 so we can get an updated release. Also related to #6 but does not refactor the project for latest Laravel standards.

coveralls commented 5 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling dfd1c3d7260493435c297e74293950ea5e69a13d on Lednerb:fix/monolog-use-files into c118229c923fffd0dce8510f57a7817edffe4e1a on stevegrunwell:fix/monolog-use-files.

Lednerb commented 5 years ago

Maybe it would be the easist way to tag the project with different version numbers.

Maybe v1 is compatible until Laravel 5.5. Laravel 5.5 (LTS Version) requires PHP Version >= 7.0.0

https://github.com/laravel/laravel/blob/3a50f43c3be644f6168bf888af272425efb8f65c/composer.json#L8

Laravel 5.6 does not receive any security- or bug-fixes anymore. Laravel 5.7 only get's security updates until September 2019.

https://laravel.com/docs/5.8/releases#support-policy

Maybe it's enough to implement v2 that is compatible with Laravel 5.8 and above because every new user that want to use lost-in-translation should upgrade his project to the latest version if he works on it anyway (otherwise he would not composer require this package).

Regarding my above statement, I've removed compatibility checks with PHP Version < 7.2.

stevegrunwell commented 5 years ago

I agree that having a version compatible with LTS releases of Laravel is a great idea, and fits well with semver. I need some time to give this project some love, but these fixes are a welcome change, thank you!