search

stevegrunwell / lost-in-translation

Uncover missing translations and localization strings in Laravel applications.
https://stevegrunwell.com/blog/find-missing-laravel-translations/
MIT License
36 stars 8 forks source link

Rewrite tests, inject Logger instance #8

Closed stevegrunwell closed 5 years ago

stevegrunwell commented 5 years ago

This PR is mainly focused on refreshing the test suite, making better use of DI and PHPUnit's --testdox runner.

Along with all of the test refactoring, a Logger instance is now being explicitly injected into the Translator class constructor, rather than calling logger().

coveralls commented 5 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling 5bc86e0325bceddd903652214bad3174bbd441a2 on refactor/tests into 4fb656bad99e313375969117de566c8c859fbbb4 on develop.