Closed killua99 closed 2 years ago
Also I added the option to identify a global installation.
I update the README file with the information about how to use it.
Luigi,
Thanks for the PR, and my apologies for the radio silence. Hoping to be able to look at this shortly!
Perhaps it will require a few minor tweaks. But please do a quick look of the README file and then try it out.
@stevegrunwell any change you might take a peek at this MR? I would be really useful for us :)
@richardsweeney My apologies, I've been swamped with work as of late. Will try to look as soon as I can get myself in a good shell scripting headspace :)
@johnpbloch thanks for taking a look and the great notes! Maybe I should have had you look this over when I first wrote the package ;)
@killua99, if you're still interested, I'm on board with merging once you address those three comments from @johnpbloch, and sorry again that this has taken forever to get around to.
Yes I am available to do it, just give me some time, I swear it won't take long 🤣😅
One thing I'll never do is rush people on open-source work. Something about a pot and kettle... 😉
I hope the response on comment made more clear why that code is there, and how does it work. Also I tried to correct some typo error that, as a non native english speaker I make.
What else would I need to get this merge ?
Day 44532,
They still haven't notice me
@stevegrunwell Let's make this happen :D I'm stoked about these changes
Some times we have our vendor folder in a bellow level where the .git folder is. With this case we can't call ./vendor/bin/phpcs
We could have it in ./web/vendor/bin/phpcs
With this patch you can do it.