Optimise Table - Githubissues

stevehalliwell / ulox

A bytecode interpreted scripting language for games in Unity.

MIT License

24 stars 0 forks source link

Optimise Table #190

Closed stevehalliwell closed 9 months ago

stevehalliwell commented 1 year ago

We are using Dictionary with HashedString key type:

investigate using int as key directly instead of via comparer
copy from source and slim down the dictionary class
- it does a lot we don't need
- it doesn't do a few things we really want, such as SetOrAdd

stevehalliwell commented 1 year ago

Top normal, bottom changing Table to be int key

stevehalliwell commented 1 year ago

look into https://github.com/Wsm2110/Faster.Map

stevehalliwell commented 1 year ago

we also want to replace use of .net dict as the unity version does not allow foreach look of dict values. That was added in 5.0 apparently.

stevehalliwell commented 1 year ago

chase up

https://github.com/TheNumbat/hashtables
https://github.com/skarupke/flat_hash_map
and potentially khash in https://github.com/attractivechaos/klib

stevehalliwell commented 1 year ago

Tested a refactor of our table class to limit its interface and replace its internals with a linear array. The intent to see how bad the structure could be before spending more time trying to make it good. The impact was only around 15%. This was less than expected and helps put into context the actual cost we are paying in table lookups vs the total execution time.