search

stevehoover / warp-v

WARP-V is an open-source RISC-V CPU core generator written in TL-Verilog.
https://warp-v.org
BSD 3-Clause "New" or "Revised" License
223 stars 54 forks source link

modified start and build statements #114

Open Jyotiraditya7 opened 9 months ago

Jyotiraditya7 commented 9 months ago

In newer versions of Node.js, the default provider for OpenSSL has been changed, and this might not be backward compatible with certain older applications or libraries that depend on the legacy behavior of OpenSSL. The –openssl-legacy-provider flag forces Node.js to use the legacy provider, which is why it resolves the issue.

netlify[bot] commented 9 months ago

Deploy Preview for warp-v failed.

Name Link
Latest commit 97273f2d6edb90d1662f6a762bfd210b0710edc4
Latest deploy log https://app.netlify.com/sites/warp-v/deploys/65a2d44072cf60000891204e
stevehoover commented 9 months ago

Looks like node would have to be bumped to a newer version in CI (and in my own local environment) in order to merge this change.

stevehoover commented 8 months ago

Oops. This still has the issue of breaking deployment due to:

/opt/buildhome/.nvm/versions/node/v16.20.2/bin/node: bad option: --openssl-legacy-provider

Please look into this as a priority. I did some digging, and I believe this needs a newer version:

configurator/package.json: "react-scripts": "4.0.3",

Jyotiraditya7 commented 8 months ago

Okay, so the Node.js version is probably causing the compatibility error

Jyotiraditya7 commented 8 months ago

The --openssl-legacy-provider option is needed when using the latest version of Node.js, because [Node.js 17 and later uses OpenSSL 3.0] which has had some breaking changes. However older version like v16 (being used in the checks) doesn't seem to require the openssl option in the start and build statements.

Jyotiraditya7 commented 8 months ago

I can create a PR with the original build statement inplace ( yarn build) and only the start statement modified, if that is needed