search

stevehuanghe / image_captioning

Image captioning models in PyTorch
Apache License 2.0
37 stars 10 forks source link

regularizing attention weights #5

Open hello1910 opened 5 years ago

hello1910 commented 5 years ago

Hi!

Thanks so much for such a great code base. I noticed that the implementation of sca-cnn by the original authors applied doubly stochastic regularization to the attention context vectors.

I wasn't able to find this in your code, but I wasn't sure if it was an error on my part.

stevehuanghe commented 5 years ago

Hi,

Thanks for reminding me. Sorry that I haven't implemented the regularization as I was only trying to compare different attention mechanisms. But I will keep improving the code to fully implement SCA-CNN.