steveicarus / iverilog

Icarus Verilog
https://steveicarus.github.io/iverilog/
GNU General Public License v2.0
2.79k stars 520 forks source link

[SDF] Tracking Issue #943

Open mole99 opened 1 year ago

mole99 commented 1 year ago

This issue tracks all open issues regarding Standard Delay Format (SDF) support in Icarus Verilog. Additionally, issues for specify are listed as they are often related.

SDF

Specify

Source Forge Issues:

SDF

Specify

caryr commented 1 year ago

There is also pull request #896.

caryr commented 1 year ago

For the pieces that are not implemented or working correctly you may want to consider parsing them and ignoring them after emitting a warning either in the RTL parser or the SDF parser. You can then get the compiler to handle the RTL part correctly and have the targets emit the warning or do the correct thing.

There is also the implementation of path delays which is needed for SDF interconnect delays. I think there is an old PR for that.

mole99 commented 1 year ago

Yes, that's what I would like to do for every unsupported feature. If you know any unsupported feature that needs a warning just tell me and I will add it.

Do you maybe recall what this PR was named? I searched with the keywords path, delay and interconnect but could not find anything.

caryr commented 1 year ago

Here are some other SF PRs:

https://sourceforge.net/p/iverilog/bugs/740/ - timing checks https://sourceforge.net/p/iverilog/bugs/273/ - wire delays

There are also a couple other PRs that will be fixed when SF-495 is fixed. I can help you track those down later.

mole99 commented 1 year ago

Thanks for the issues, I have added them to the list.

It seems we have a different understanding of what a PR is :) Pull Request (PR) is GitHub jargon for when you want to add new features to a branch. If you are using GitLab, it is called Merge Request (MR) there.

See here for a better explanation: pull-request-vs-merge-request

caryr commented 1 year ago

If you notice many of the tests start or have pr in their title. I believe this is done to indicate the problem report they where initially ties to. We added gh to indicate they are from github instead of SourceForge. It's sometimes useful when we need to track a change back to an initial request. Of course it didn't help when SF reordered the reports to be project specific.

mole99 commented 1 year ago

Oh, I see! I have wondered why they are named that way ^^

martinwhitaker commented 8 months ago

Would it be better to add a new "SDF" label rather than have a tracking issue? You could then use the filter expression "label:SDF" to find all the relevant issues.

mole99 commented 8 months ago

That's a great idea! But I don't think I have the permission to create and assign labels. Maybe someone else could do that?

caryr commented 8 months ago

I added a specify/SDF tag. I marked the issues on the first page using this tag. We need to mark the rest and then this can be closed except this report does still have some benefit since it references the SourceForge bug reports.